Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: project path case sensitivity #1857

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: project path case sensitivity #1857

merged 1 commit into from
May 3, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented May 2, 2024

/deploy

@olevski olevski requested a review from a team as a code owner May 2, 2024 21:50
@olevski olevski temporarily deployed to renku-ci-nb-1857 May 2, 2024 21:50 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented May 2, 2024

You can access the deployment of this PR at https://renku-ci-nb-1857.dev.renku.ch

@olevski
Copy link
Member Author

olevski commented May 2, 2024

Different gitlab api endpoints return all-lowercase or case sensitive names for the project name/path. But for mount locations or work-dirs we use the case sensitive version.

For example try to launch a session from this project on dev.renku.ch and the work dir will be wrong.
https://renku-ci-nb-1856.dev.renku.ch/projects/tasko.olevski/anewproject

Prior to adding the support for multiple repos we were using the case sensitive path name of the project for the mount dir. So in this fix I went for the same. For renku 2.0 we should make sure we just go for lowercase across the board or something like that.

Steven reported this issue on slack. The streamlit app here (https://renkulab.io/projects/deeplnafrica/deepLNAfrica) does not work because the project is cloned in /work/deeplnafrica but the workdir is /work/deepLNAfrica.

@olevski olevski merged commit b383f2d into master May 3, 2024
15 checks passed
@olevski olevski deleted the fix-cloning-repos branch May 3, 2024 11:08
@leafty
Copy link
Member

leafty commented May 3, 2024

@olevski For Renku 2.0, all sessions have their working directory set to <image_work_dir>/work, so this should not be an issue.

I will check that this case is handled correctly in #1849.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants