feat(cli): allow setting local port on session docker provider (#3350)

SwissDataScienceCenter · Mar 14, 2023 · 5fdac71 · 5fdac71
1 parent 6798b1a
commit 5fdac71
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/renku/core/session/docker.py b/renku/core/session/docker.py
@@ -121,7 +121,11 @@ def session_provider(self) -> ISessionProvider:
 
     def get_start_parameters(self) -> List["ProviderParameter"]:
         """Returns parameters that can be set for session start."""
-        return []
+        from renku.core.dataset.providers.models import ProviderParameter
+
+        return [
+            ProviderParameter("port", help="Local port to use (random if not specified).", type=int),
+        ]
 
     def get_open_parameters(self) -> List["ProviderParameter"]:
         """Returns parameters that can be set for session open."""
@@ -243,7 +247,7 @@ def session_start_helper(consider_disk_request: bool):
                     f" --NotebookApp.notebook_dir={work_dir}" + (" --allow-root" if os.getuid() != 1000 else ""),
                     detach=True,
                     labels={"renku_project": project_name, "jupyter_token": auth_token},
-                    ports={f"{DockerSessionProvider.JUPYTER_PORT}/tcp": None},
+                    ports={f"{DockerSessionProvider.JUPYTER_PORT}/tcp": kwargs.get("port")},
                     remove=True,
                     environment=environment,
                     volumes=volumes,