Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): allow setting local port on session docker provider #3350

Merged
merged 3 commits into from
Mar 14, 2023
Merged

feat(cli): allow setting local port on session docker provider #3350

merged 3 commits into from
Mar 14, 2023

Conversation

Panaetius
Copy link
Member

closes #3322

@Panaetius Panaetius requested a review from a team as a code owner March 6, 2023 11:18
@coveralls
Copy link
Collaborator

coveralls commented Mar 6, 2023 •
edited

Pull Request Test Coverage Report for Build 4413347106

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+86.7%) to 86.68%
Totals Coverage Status
Change from base Build 4413346086: 86.7%
Covered Lines: 25627
Relevant Lines: 29565
💛 - Coveralls

@Panaetius Panaetius merged commit 5fdac71 into develop Mar 14, 2023
@Panaetius Panaetius deleted the feature/3322-select-local-docker-port branch March 14, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to select port when running a renku session locally
3 participants
@Panaetius @coveralls @olevski