address PR comments

renku/command/command_builder/database.py

@@ -84,7 +84,10 @@ def _injection_pre_hook(self, builder: Command, context: dict, *args, **kwargs)
             try:
                 with open(client.database_path / "project", "r") as f:
                     project = json.load(f)
-                    minimum_renku_version = Version(project.get("minimum_renku_version"))
+                    min_version = project.get("minimum_renku_version")
+                    if min_version is None:
+                        return
+                    minimum_renku_version = Version(min_version)
             except (KeyError, OSError, json.JSONDecodeError):
                 # NOTE: We don't check minimum version if there's no project metadata available
                 return

renku/domain_model/project.py

@@ -29,6 +29,7 @@
 from renku.core.util.os import normalize_to_ascii
 from renku.domain_model.provenance.agent import Person
 from renku.domain_model.provenance.annotation import Annotation
+from renku.version import __minimum_project_version__
 
 
 class Project(persistent.Persistent):
@@ -37,8 +38,8 @@ class Project(persistent.Persistent):
     keywords: List[str] = list()
 
     # NOTE: the minimum version of renku to needed to work with a project
-    # This should be bumped on metadata version changes and when we do non forward-compatible on-the-fly migrations
-    minimum_renku_version: str = "1.2.0"
+    # This should be bumped on metadata version changes and when we do not forward-compatible on-the-fly migrations
+    minimum_renku_version: str = __minimum_project_version__
 
     def __init__(
         self,

renku/version.py

@@ -26,6 +26,7 @@
 
 __version__ = "0.0.0"
 __template_version__ = "0.3.1"
+__minimum_project_version__ = "1.2.0"
 
 
 def is_release():

tests/core/commands/test_renku.py

@@ -55,7 +55,7 @@ def mocked_getter(self, key):
         try:
             Command().command(lambda: "").with_database(write=False).build().execute()
         except errors.MinimumVersionError:
-            assert False, "Shouldn't raise an exception"
+            pytest.fail("Shouldn't raise an exception.")
 
         # NOTE: Check doesn't raise with higher current version
         mocker.patch("renku.domain_model.project.Project.minimum_renku_version", "0.9.0")
@@ -64,7 +64,7 @@ def mocked_getter(self, key):
         try:
             Command().command(lambda: "").with_database(write=False).build().execute()
         except errors.MinimumVersionError:
-            assert False, "Shouldn't raise an exception"
+            pytest.fail("Shouldn't raise an exception.")
         assert "0.9.0" == project.minimum_renku_version
 
         # NOTE: Check that accessing a project with newer version fails
@@ -84,7 +84,7 @@ def mocked_getter(self, key):
         try:
             Command().command(lambda: "").with_database(write=False).build().execute()
         except errors.MinimumVersionError:
-            assert False, "Shouldn't raise an exception"
+            pytest.fail("Shouldn't raise an exception.")
 
         # NOTE: Assert that minimum_version is increased on write
         mocker.patch("renku.domain_model.project.Project.minimum_renku_version", "1.0.0")
@@ -94,5 +94,5 @@ def mocked_getter(self, key):
         try:
             Command().command(lambda: "").with_database(write=True).build().execute()
         except errors.MinimumVersionError:
-            assert False, "Shouldn't raise an exception"
+            pytest.fail("Shouldn't raise an exception.")
         assert "1.0.0" == project.minimum_renku_version