Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): add support for using default values in template parameters #3550

Merged
merged 1 commit into from Jul 5, 2023

Conversation

Panaetius
Copy link
Member

SwissDataScienceCenter/renku-project-template@56aa0a2 added a template parameter to our templates, breaking RP tests. This PR adds proper support for using default values for template parameters.

@Panaetius Panaetius requested a review from a team as a code owner July 5, 2023 15:20
@Panaetius Panaetius enabled auto-merge (squash) July 5, 2023 15:23
@Panaetius Panaetius merged commit d162392 into develop Jul 5, 2023
27 of 30 checks passed
@Panaetius Panaetius deleted the fix-tests branch July 5, 2023 15:52
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5466058021

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 128 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.2%) to 85.508%

Files with Coverage Reduction New Missed Lines %
renku/core/errors.py 1 83.52%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/util/tabulate.py 1 96.3%
renku/core/workflow/activity.py 1 93.61%
renku/ui/cli/dataset.py 1 89.77%
renku/ui/cli/init.py 1 96.9%
renku/ui/service/controllers/templates_create_project.py 1 95.18%
renku/core/dataset/dataset.py 6 76.3%
renku/core/dataset/tag.py 9 74.29%
renku/core/util/communication.py 9 91.85%
Totals Coverage Status
Change from base Build 5462986423: -0.2%
Covered Lines: 25720
Relevant Lines: 30079

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants