Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFS support for renga run #116

Merged
merged 5 commits into from
Feb 27, 2018

Conversation

rokroskar
Copy link
Member

@rokroskar rokroskar commented Feb 23, 2018

  • initialize LFS on project init
  • track CWL tool outputs in LFS

waiting on #115 before adding the integration for datasets


addresses #104

@rokroskar rokroskar requested a review from a team as a code owner February 23, 2018 17:02
@@ -68,12 +68,13 @@ def store_directory(ctx, param, value):
exists=True, writable=True, file_okay=False, resolve_path=True))
@click.option('--name', callback=validate_name)
@click.option('--force', is_flag=True)
@click.option('--lfs/--nolfs', is_flag=True, default=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--lfs/--no-lfs

Copy link
Contributor

@jirikuncar jirikuncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove mentions of LFS from the method names? I would propose to use technology agnostic name like "object store(-age)" or "file store(-age)".

@rokroskar rokroskar changed the title [WIP] LFS support LFS support Feb 26, 2018
@rokroskar rokroskar changed the title LFS support LFS support for renga run Feb 26, 2018
@jirikuncar jirikuncar merged commit 74f7f15 into SwissDataScienceCenter:development Feb 27, 2018
@jirikuncar jirikuncar deleted the lfs branch February 27, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants