-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(service): disable migration check optimization for anonymous sessions #2541
fix(service): disable migration check optimization for anonymous sessions #2541
Conversation
4db8931
to
9b1dc4e
Compare
Maybe for anonymous users we should just go the slow route instead of disabling it ( |
- Allow anonymous users to invoke renku-core APIs (where possible) - Switch to using git_url + branch for migrations instead of project_id BREAKING CHANGE: requires SwissDataScienceCenter/renku-python#2541 re #1507
- Allow anonymous users to invoke renku-core APIs (where possible) - Switch to using git_url + branch for migrations instead of project_id BREAKING CHANGE: requires SwissDataScienceCenter/renku-python#2541 re #1507
- Allow anonymous users to invoke renku-core APIs (where possible) - Switch to using git_url + branch for migrations instead of project_id BREAKING CHANGE: requires SwissDataScienceCenter/renku-python#2541 re #1507
9b1dc4e
to
25283b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hold on, we "accidentally" tried this on SwissDataScienceCenter/renku-ui#1630 (we re-deployed after the last changes) and we noticed a problem with logged users Atm we switched to another branch taken from the previous commit, so it will work if you try on the UI CI deployment.
|
That's weird. So the token sent in the JWT with that user does not have access to that repo through gitlab API, even though the repo is owned by that user. |
You can access the deployment of this PR at https://renku-ci-rp-2541.dev.renku.ch |
That seems to be an issue also on public projects, where an invalid token shouldn't be a problem . Anyway, I modified the initial message to trigger a CI deployment. |
- Allow anonymous users to invoke renku-core APIs (where possible) - Switch to using git_url + branch for migrations instead of project_id BREAKING CHANGE: requires SwissDataScienceCenter/renku-python#2541 re #1507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Disable optimized
/cache.migrations_check
for now./deploy renku=1.0-next renku-graph=cli-v1 renku-ui=1507b-migrations-giturl #notest