fix(service): disable migration check optimization for anonymous sessions

renku/service/controllers/cache_migrations_check.py

@@ -25,7 +25,6 @@
 from renku.core.utils.contexts import click_context
 from renku.service.controllers.api.abstract import ServiceCtrl
 from renku.service.controllers.api.mixins import RenkuOperationMixin
-from renku.service.controllers.utils.remote_project import ANONYMOUS_SESSION
 from renku.service.interfaces.git_api_provider import IGitAPIProvider
 from renku.service.serializers.cache import ProjectMigrationCheckRequest, ProjectMigrationCheckResponseRPC
 from renku.service.views import result_response
@@ -61,7 +60,7 @@ def _fast_op_without_cache(self):
                 tempdir,
                 remote=self.ctx["git_url"],
                 ref=self.request_data.get("ref", None),
-                token=self.user_data.get("token", ANONYMOUS_SESSION),
+                token=self.user_data.get("token", None),
             )
             with click_context(tempdir, "renku_op"):
                 return self.renku_op()
@@ -72,9 +71,11 @@ def renku_op(self):
 
     def to_response(self):
         """Execute controller flow and serialize to service response."""
+        return result_response(self.RESPONSE_SERIALIZER, self.execute_op())
 
-        if "project_id" in self.context:
-            # use regular flow using cache
-            return result_response(self.RESPONSE_SERIALIZER, self.execute_op())
-
-        return result_response(self.RESPONSE_SERIALIZER, self._fast_op_without_cache())
+        # TODO: Enable this optimization. See https://github.com/SwissDataScienceCenter/renku-python/issues/2546
+        # if "project_id" in self.context:
+        #     # use regular flow using cache
+        #     return result_response(self.RESPONSE_SERIALIZER, self.execute_op())
+        #
+        # return result_response(self.RESPONSE_SERIALIZER, self._fast_op_without_cache())

renku/service/views/cache.py

@@ -31,6 +31,7 @@
     accepts_json,
     handle_common_except,
     handle_migration_except,
+    optional_identity,
     requires_cache,
     requires_identity,
 )
@@ -182,7 +183,7 @@ def migrate_project_view(user_data, cache):
 @cache_blueprint.route("/cache.migrations_check", methods=["GET"], provide_automatic_options=False, versions=[V1_0])
 @handle_common_except
 @requires_cache
-@requires_identity
+@optional_identity
 def migration_check_project_view(user_data, cache):
     """
     Retrieve migration information for a project.

renku/service/views/v0_9/cache.py

@@ -22,12 +22,12 @@
 from renku.service.gateways.gitlab_api_provider import GitlabAPIProvider
 from renku.service.serializers.v0_9.cache import ProjectMigrationCheckResponseRPC_0_9
 from renku.service.views.api_versions import V0_9
-from renku.service.views.decorators import handle_common_except, requires_cache, requires_identity
+from renku.service.views.decorators import handle_common_except, optional_identity, requires_cache
 
 
 @handle_common_except
 @requires_cache
-@requires_identity
+@optional_identity
 def migration_check_project_view_0_9(user_data, cache):
     """
     Retrieve migration information for a project.

tests/service/fixtures/service_projects.py

@@ -63,6 +63,12 @@ def it_remote_repo_url():
     return IT_REMOTE_REPO_URL
 
 
+@pytest.fixture(scope="module")
+def it_remote_public_repo_url():
+    """Returns a remote path to a public integration test repository."""
+    return "https://dev.renku.ch/gitlab/renku-python-integration-tests/no-renku"
+
+
 @pytest.fixture(scope="function")
 def it_remote_repo_url_temp_branch(it_remote_repo_url):
     """Returns a remote path to integration test repository."""

tests/service/views/test_cache_views.py

@@ -806,3 +806,16 @@ def test_cache_gets_synchronized(
 
     assert any(d.name == "my_dataset" for d in datasets)
     assert any(d.name == payload["name"] for d in datasets)
+
+
+@pytest.mark.service
+@pytest.mark.integration
+def test_check_migrations_remote_anonymous(svc_client, it_remote_public_repo_url):
+    """Test anonymous users can check for migration of public projects."""
+    response = svc_client.get(
+        "/1.0/cache.migrations_check", query_string={"git_url": it_remote_public_repo_url}, headers={}
+    )
+
+    assert 200 == response.status_code
+
+    assert response.json["result"]["core_compatibility_status"]["migration_required"] is True

tests/service/views/v0_9/test_cache_views_0_9.py

@@ -72,3 +72,16 @@ def test_check_no_migrations_0_9(svc_client_with_repo):
     assert not response.json["result"]["template_update_possible"]
     assert not response.json["result"]["docker_update_possible"]
     assert response.json["result"]["project_supported"]
+
+
+@pytest.mark.service
+@pytest.mark.integration
+def test_check_migrations_remote_anonymous_0_9(svc_client, it_remote_public_repo_url):
+    """Test anonymous users can check for migration of public projects."""
+    response = svc_client.get(
+        "/0.9/cache.migrations_check", query_string={"git_url": it_remote_public_repo_url}, headers={}
+    )
+
+    assert 200 == response.status_code
+
+    assert response.json["result"]["migration_required"] is True