feat(service): restore optimized migration check #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle the GitLab library specific errors. - fall back to full repository checkout in case of unforseen errors. fix #2546
|
You can access the deployment of this PR at https://renku-ci-rp-2854.dev.renku.ch |
Panaetius
requested changes
Apr 25, 2022
use `BaseException` instead of `Exception` to catch all the remaining exceptions Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
|
I added a test with a public repo, to be sure we don't break that for the optimized migrations checks (although that |
Panaetius
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the optimized migration check for the service.
The problem was mainly caused by invalid GitLab tokens that trigger errors when passed to the
gitlabpython library -- quite unexpected considering the different outcomes when invoking similar GitLab APIs with the same expired/invalid tokens.In short, I added logic to:
gitlablibrary common errors./deploy
fix #2546