Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optimized migration check for users with an invalid auth #2546

Closed
m-alisafaee opened this issue Dec 29, 2021 · 2 comments · Fixed by #2854
Closed

Fix optimized migration check for users with an invalid auth #2546

m-alisafaee opened this issue Dec 29, 2021 · 2 comments · Fixed by #2854
Assignees
@lorenzo-cavazzi
Labels
kind/bug

Comments

@m-alisafaee
Copy link
Contributor

m-alisafaee commented Dec 29, 2021 •
edited

#2432 implements an optimized migration check by downloading only necessary files. However, if a user's access token is invalid, this optimization raises an exception even for public projects.
@m-alisafaee m-alisafaee mentioned this issue Jan 10, 2022
Merged
@m-alisafaee m-alisafaee self-assigned this Jan 11, 2022
@m-alisafaee m-alisafaee changed the title Add support for anonymous session in the optimized migration check Fix optimized migration check for users with an invalid auth Jan 14, 2022
@m-alisafaee
Copy link
Contributor Author

It seems that gitlab raises an authorization error even for public repos when an auth header is provided. For example, curl -H 'Authorization: Bearer 12345' https://dev.renku.ch/gitlab/api/v4/projects/renku-python-integration-tests%2Fno-renku fails while curl https://dev.renku.ch/gitlab/api/v4/projects/renku-python-integration-tests%2Fno-renku works.

@m-alisafaee m-alisafaee removed their assignment Feb 2, 2022
@Panaetius
Copy link
Member

Also change it so it falls back to the normal code if the optimized Gitlab code fails.

lorenzo-cavazzi added a commit to lorenzo-cavazzi/renku-python that referenced this issue Apr 22, 2022
@lorenzo-cavazzi
feat(service): restore optimized migration check
7254a91 
- handle the GitLab library specific errors.
- fall back to full repository checkout in case of unforseen errors.

fix SwissDataScienceCenter#2546
lorenzo-cavazzi added a commit that referenced this issue Apr 22, 2022
@lorenzo-cavazzi
feat(service): restore optimized migration check
2a1e9f5 
- handle the GitLab library specific errors.
- fall back to full repository checkout in case of unforseen errors.

fix #2546
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue Apr 22, 2022
Merged
lorenzo-cavazzi added a commit that referenced this issue Apr 27, 2022
@lorenzo-cavazzi
feat(service): restore optimized migration check (#2854)
7e2a3d4 
- handle the GitLab library specific errors.
- fall back to full repository checkout in case of unforeseen errors.

fix #2546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(service): restore optimized migration check SwissDataScienceCenter/renku-python
3 participants
@Panaetius @lorenzo-cavazzi @m-alisafaee