Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support object variables from the template manifest #1320

Closed
lorenzo-cavazzi opened this issue Apr 20, 2021 · 1 comment
Closed

Support object variables from the template manifest #1320

lorenzo-cavazzi opened this issue Apr 20, 2021 · 1 comment
Assignees
@lorenzo-cavazzi

Comments

@lorenzo-cavazzi
Copy link
Member

lorenzo-cavazzi commented Apr 20, 2021 •
edited
Loading

On the project creation page, we show the corresponding variables when the user picks a template. Currently, we accept any input. Once SwissDataScienceCenter/renku-python#2034 is addressed, we can support <select> and typed inputs. We should consider the default values too, when available.

We will need to update the code to the new response from the GET /templates.read_manifest endpoint -- basically, the variables field will be an array of objects. Check the renku-python issue for the details
@gavin-k-lee gavin-k-lee mentioned this issue Apr 22, 2021
Open
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Jun 7, 2021
lorenzo-cavazzi added a commit that referenced this issue Nov 19, 2021
@lorenzo-cavazzi
feat(client): support template variables metadata
89655df 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
lorenzo-cavazzi added a commit that referenced this issue Nov 19, 2021
@lorenzo-cavazzi
feat(client): support template variables metadata
21b9d8f 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue Nov 19, 2021
Merged
lorenzo-cavazzi added a commit that referenced this issue Dec 6, 2021
@lorenzo-cavazzi
feat(client): support template variables metadata
07b10da 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
lorenzo-cavazzi added a commit that referenced this issue Dec 15, 2021
@lorenzo-cavazzi
feat(client): support template variables metadata (#1579)
da08f47 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
lorenzo-cavazzi added a commit that referenced this issue Dec 15, 2021
@lorenzo-cavazzi
feat(client): support template variables metadata (#1579)
ab71abf 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
ciyer pushed a commit that referenced this issue Dec 16, 2021
@lorenzo-cavazzi @cramakri
feat(client): support template variables metadata (#1579)
d59565e 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
lorenzo-cavazzi added a commit that referenced this issue Dec 17, 2021
@lorenzo-cavazzi
feat(client): support template variables metadata (#1579)
58b0538 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
@lorenzo-cavazzi
Copy link
Member Author

closed in #1579

lorenzo-cavazzi added a commit that referenced this issue Dec 17, 2021
@lorenzo-cavazzi
feat(client): support template variables metadata (#1579)
a6bf546 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
lorenzo-cavazzi added a commit that referenced this issue Dec 21, 2021
@lorenzo-cavazzi
feat(client): support template variables metadata (#1579)
4c55fcc 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
lorenzo-cavazzi added a commit that referenced this issue Jan 3, 2022
@lorenzo-cavazzi
feat(client): support template variables metadata (#1579)
2d29997 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
lorenzo-cavazzi added a commit that referenced this issue Jan 7, 2022
@lorenzo-cavazzi
feat(client): support template variables metadata (#1579)
d550931 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
ciyer pushed a commit that referenced this issue Jan 26, 2022
@lorenzo-cavazzi @ciyer
feat(client): support template variables metadata (#1579)
611163a 
* Style and show input elements based on the variable type.
* Automatically set default values.

fix #1320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorenzo-cavazzi