feat: handle non blocking errors on fork #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-1351.dev.renku.ch |
ciyer
approved these changes
May 19, 2021
|
I pushed a minor change to prevent linting errors |
ciyer
approved these changes
May 21, 2021
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the UX when a non-fatal error occurs while forking (i.e. the pipeline or webhook creation fails)
How to test: it's a bit tricky. The easiest way is running telepresence on the PR environment and manually modifying the code in the
client.forkProjectfunction to trigger the error on the target API (try with the main fork API, then withrunPipelineandcreateGraphWebhook)P.S. mind that the error message is slightly different than the suggested one, to keep it coherent with the other cases. Feel free to suggest changes if it's not clear (or change it directly in the PR).
/deploy renku=ui-design-test-fix
fix #1341