Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): update S3 sources descriptions #2207

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Dec 9, 2022

Update description for S3 services

/deploy #persist
fix #2198

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner December 9, 2022 10:15
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2207 December 9, 2022 10:15 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Dec 9, 2022

You can access the deployment of this PR at https://renku-ci-ui-2207.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2207 December 12, 2022 08:18 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2207 December 12, 2022 10:53 — with GitHub Actions Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- I extracted the common code into a component (will make it easier to update the link in the future if necessary) and reworded the message slightly.

@ciyer ciyer deployed to renku-ci-ui-2207 December 12, 2022 12:45 — with GitHub Actions Active
@lorenzo-cavazzi
Copy link
Member Author

Thank you for the addition! 🙏

@lorenzo-cavazzi lorenzo-cavazzi merged commit 978ada2 into master Dec 12, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the 2198-blob-storage branch December 12, 2022 13:18
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

We cannot mount azure blob storage in sessions
4 participants