Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image orientation based on EXIF data #63

Merged
merged 6 commits into from
Mar 12, 2015
Merged

Fix image orientation based on EXIF data #63

merged 6 commits into from
Mar 12, 2015

Conversation

jdecool
Copy link
Collaborator

@jdecool jdecool commented Mar 6, 2015

Proposal for issue #62

PHP doesn't have a proper method to write EXIF data. EXIF data contain image orientation which is used by many camera to display image in the right orientation.

This PR read EXIF and apply a transformation to image to keep it in right orientation.

PS: you can used this images to tests the code (https://drive.google.com/file/d/0B-bWnVSgvyP-Vmp3T0ZCd1ZBb2s/view?usp=sharing)

@jdecool
Copy link
Collaborator Author

jdecool commented Mar 12, 2015

I just add an EXIF orientations container to have a cleaner and clearer code.

@Sybio Do you agree with this PR ? If it's OK for you, I will merge it.

Sybio added a commit that referenced this pull request Mar 12, 2015
Fix image orientation based on EXIF data
@Sybio Sybio merged commit 5d4d5e8 into Sybio:master Mar 12, 2015
@Sybio
Copy link
Owner

Sybio commented Mar 12, 2015

Everything ok it's merged. Good work !

@jdecool
Copy link
Collaborator Author

jdecool commented Mar 12, 2015

Thanks

@jdecool jdecool mentioned this pull request Mar 12, 2015
@jdecool jdecool deleted the exif-data branch March 27, 2015 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants