-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding features #11 #121
Merged
Merged
Adding features #11 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the bestseller option - when 'see all' option is selected.
Updated the review.html page.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey SyedImtiyaz,
Just wanted to give you a heads up that the issue has been resolved. Please
take a look at it. Also, this is my last PR and I'm one step away from
completing my 4 PRs.
Thanks!
Payal
…On Thu, Oct 12, 2023 at 2:08 AM vercel[bot] ***@***.***> wrote:
*The latest updates on your projects*. Learn more about Vercel for Git ↗︎
<https://vercel.link/github-learn-more>
Name Status Preview Comments Updated (UTC)
*codeshop* ✅ Ready (Inspect
<https://vercel.com/syedimtiyaz-1/codeshop/4cq5p9ZJ1ZUz3QYPypffxHCaW4j1>) Visit
Preview
<https://vercel.live/open-feedback/codeshop-git-fork-payallenka-master-syedimtiyaz-1.vercel.app?via=pr-comment-visit-preview-link&passThrough=1> 💬
*Add feedback*
<https://vercel.live/open-feedback/codeshop-git-fork-payallenka-master-syedimtiyaz-1.vercel.app?via=pr-comment-feedback-link> Oct
11, 2023 8:38pm
—Reply to this email directly, view it on GitHub
<#121 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT6EWI3RQHJEJPIHOPDBHVTX637UJANCNFSM6AAAAAA54SLGME>.You
are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue which was in collaboration with @Khushi-Gupta13 is completed.
Addon to the review tab - some pre-reviews of some products.
Moreover - bestseller section is added, customized for every category - it is displayed when 'See all' option is selected by the user (it is present at the end of every section).
Additionally - a bug has been fixed:
The website wasn't able to fetch the './index.html` at time when 'Home' option was selected by the user. This issue was caught while going to previous tab from the "About Us' tab.
The link was changed from './index.html' to '/Code-shop-master'.