Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache provider fix #408

Open
wants to merge 2 commits into
base: 1.12
Choose a base branch
from
Open

Cache provider fix #408

wants to merge 2 commits into from

Conversation

liszkapawel
Copy link

@liszkapawel liszkapawel commented Sep 23, 2023

It looks like the plugin skeleton has an outdated doctrine configuration for the production and test_cached environment
Refs: #407

@liszkapawel liszkapawel requested a review from a team as a code owner September 23, 2023 12:11
result_cache_driver:
type: service
id: doctrine.result_cache_provider
entity_managers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should upgrade to when@prod syntax for multi env configs at a single file, which is already available to us https://symfony.com/blog/new-in-symfony-5-3-configure-multiple-environments-in-a-single-file

But it needs to be scheduled for all repos. @Sylius/core-team WDYT?

arguments:
- '@doctrine.system_cache_pool'


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra empty line


services:
doctrine.result_cache_provider:
class: Symfony\Component\Cache\DoctrineProvider
class: Doctrine\Common\Cache\Psr6\DoctrineProvider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of doctrine/cache do you use? Sylius 1.12 is dependant on ^1.10, while current Sylius 1.13 (unreleased) is ^2.2, so I've a feeling this shouldn't have been an issue yet as this upgrade is only mentioned for 2.2 (But I didn't try for myself) https://www.doctrine-project.org/projects/doctrine-cache/en/2.2/index.html#use-with-psr-6

type: memcached
host: localhost
port: 11211
type: service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with PSR6 cache upgrade, I think it should have stayed with memcached, though I never looked at this part too closely before.

@jakubtobiasz should know more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants