Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the requirements regarding payment methods #165

Closed
olia-bn opened this issue Nov 15, 2019 · 0 comments · Fixed by #177
Closed

Explain the requirements regarding payment methods #165

olia-bn opened this issue Nov 15, 2019 · 0 comments · Fixed by #177
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance Configurations, READMEs, releases, etc.
Milestone
v1.0.0

Comments

@olia-bn
Copy link

olia-bn commented Nov 15, 2019

In default installation, the RefundPaymentMethodsProviderInterface returns only active payment methods of type 'offline' enabled for the order's channel.

In some installations, there might be no suitable methods; creating a refund with no payment method selected will succeed (albeit while throwing an error since RefundPayment constructor requires one; I'm not aware of any other consequences at the moment).

The default requirements for available payment methods should be explained in the README, preferably together with explanation of how to implement custom RefundPaymentMethodsProvider.
@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance Configurations, READMEs, releases, etc. labels Nov 15, 2019
@Zales0123 Zales0123 added this to the v1.0.0 milestone Dec 17, 2019
@AdamKasp AdamKasp mentioned this issue Jan 15, 2020
Merged
Zales0123 added a commit that referenced this issue Jan 16, 2020
@Zales0123
minor #177 Update README with refunds payment information (AdamKasp)
1be8716 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Fixes #165

Commits
-------

58da2eb Add update README with refunds payment information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Update README with refunds payment information AdamKasp/RefundPlugin
2 participants
@Zales0123 @olia-bn