Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inverted line in nginx configuration #607

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fix inverted line in nginx configuration #607

merged 1 commit into from
Sep 16, 2021

Conversation

vasilvestre
Copy link
Contributor

@vasilvestre vasilvestre requested a review from a team as a code owner September 14, 2021 13:45
lchrusciel
lchrusciel approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @Arminek @arti0090

@arti0090
Copy link
Contributor

To be honest I don't know if there is any difference, but if this change will make nginx gods 🙏 feel better then this is good for me 😄. In my PR from the comment I have tried to make a dynamic resolution of addresses (for example if many php containers would run) 🚀

@Zales0123 Zales0123 merged commit e6f5bb3 into Sylius:master Sep 16, 2021
@Zales0123
Copy link
Member

Thanks, Valentin! 🎉

@vasilvestre vasilvestre deleted the patch-1 branch September 24, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vasilvestre @arti0090 @Zales0123 @lchrusciel