bug #13547 [Promotion] Fix js errors associated with actions/rules/sc…

…opes (GSadee)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.11
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #13447
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

9f86619 [Promotion] Fix js errors associated with actions/rules/scopes

src/Sylius/Bundle/AdminBundle/Resources/private/js/app.js

@@ -68,17 +68,7 @@ $(document).ready(() => {
   });
   $('#sylius_promotion_rules > a[data-form-collection="add"]').on('click', () => {
     setTimeout(() => {
-      $(`select[name^="sylius_promotion[rules]"][name$="[type]"]`).last().change();
-    }, 50);
-  });
-  $('#sylius_catalog_promotion_actions > a[data-form-collection="add"]').on('click', () => {
-    setTimeout(() => {
-      $('select[name^="sylius_catalog_promotion[actions]"][name$="[type]"]').last().change();
-    }, 50);
-  });
-  $('#sylius_catalog_promotion_scopes > a[data-form-collection="add"]').on('click', () => {
-    setTimeout(() => {
-      $(`select[name^="sylius_catalog_promotion[scopes]"][name$="[type]"]`).last().change();
+      $('select[name^="sylius_promotion[rules]"][name$="[type]"]').last().change();
     }, 50);
   });
 
@@ -89,13 +79,17 @@ $(document).ready(() => {
       }
     });
 
-    $(document).loadCatalogPromotionScopeConfiguration(
-      document.querySelector('#sylius_catalog_promotion_scopes [data-form-collection="item"]:last-child')
-    );
+    if ($('#sylius_catalog_promotion_scopes').length > 0) {
+      $(document).loadCatalogPromotionScopeConfiguration(
+        document.querySelector('#sylius_catalog_promotion_scopes [data-form-collection="item"]:last-child')
+      );
+    }
 
-    $(document).loadCatalogPromotionActionConfiguration(
-      document.querySelector('#sylius_catalog_promotion_actions [data-form-collection="item"]:last-child')
-    );
+    if ($('#sylius_catalog_promotion_actions').length > 0) {
+      $(document).loadCatalogPromotionActionConfiguration(
+        document.querySelector('#sylius_catalog_promotion_actions [data-form-collection="item"]:last-child')
+      );
+    }
   });
   $(document).on('collection-form-update', () => {
     $('.sylius-autocomplete').each((index, element) => {

src/Sylius/Bundle/AdminBundle/Resources/private/js/sylius-catalog-promotion-actions.js

@@ -11,6 +11,10 @@ import $ from 'jquery';
 
 $.fn.extend({
   loadCatalogPromotionActionConfiguration(target) {
+    if (target == null || target.querySelector('#sylius_catalog_promotion_actions select[name*="type"]') == null) {
+      return;
+    }
+
     target.querySelector('#sylius_catalog_promotion_actions select[name*="type"]').onchange = function () {
       const parent = this.parentElement;
       const newConfig = document.createElement('div');

src/Sylius/Bundle/AdminBundle/Resources/private/js/sylius-catalog-promotion-scopes.js

@@ -11,6 +11,10 @@ import $ from 'jquery';
 
 $.fn.extend({
   loadCatalogPromotionScopeConfiguration(target) {
+    if (target == null || target.querySelector('#sylius_catalog_promotion_scopes select[name*="type"]') == null) {
+      return;
+    }
+
     target.querySelector('#sylius_catalog_promotion_scopes select[name*="type"]').onchange = function () {
       const parent = this.parentElement;
       const newConfig = document.createElement('div');