feature #15296 Improve autoconfiguration with attributes for OrderBun…

…dle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 0a26e7a Improve autoconfiguration with attributes for OrderBundle
Sylius · Sep 13, 2023 · 732adc2 · 732adc2
2 parents 6b4d085 + 0a26e7a
commit 732adc2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/Sylius/Bundle/OrderBundle/Attribute/AsCartContext.php b/src/Sylius/Bundle/OrderBundle/Attribute/AsCartContext.php
@@ -16,6 +16,8 @@
 #[\Attribute(\Attribute::TARGET_CLASS)]
 final class AsCartContext
 {
+    public const SERVICE_TAG = 'sylius.context.cart';
+
     public function __construct(
         private int $priority = 0,
     ) {

diff --git a/src/Sylius/Bundle/OrderBundle/Attribute/AsOrderProcessor.php b/src/Sylius/Bundle/OrderBundle/Attribute/AsOrderProcessor.php
@@ -16,6 +16,8 @@
 #[\Attribute(\Attribute::TARGET_CLASS)]
 final class AsOrderProcessor
 {
+    public const SERVICE_TAG = 'sylius.order_processor';
+
     public function __construct(
         private int $priority = 0,
     ) {

diff --git a/src/Sylius/Bundle/OrderBundle/DependencyInjection/SyliusOrderExtension.php b/src/Sylius/Bundle/OrderBundle/DependencyInjection/SyliusOrderExtension.php
@@ -50,13 +50,13 @@ private function registerAutoconfiguration(ContainerBuilder $container, bool $au
             $container->registerAttributeForAutoconfiguration(
                 AsCartContext::class,
                 static function (ChildDefinition $definition, AsCartContext $attribute): void {
-                    $definition->addTag(RegisterCartContextsPass::CART_CONTEXT_SERVICE_TAG, ['priority' => $attribute->getPriority()]);
+                    $definition->addTag(AsCartContext::SERVICE_TAG, ['priority' => $attribute->getPriority()]);
                 },
             );
             $container->registerAttributeForAutoconfiguration(
                 AsOrderProcessor::class,
                 static function (ChildDefinition $definition, AsOrderProcessor $attribute): void {
-                    $definition->addTag(RegisterProcessorsPass::PROCESSOR_SERVICE_TAG, ['priority' => $attribute->getPriority()]);
+                    $definition->addTag(AsOrderProcessor::SERVICE_TAG, ['priority' => $attribute->getPriority()]);
                 },
             );
         } else {