[DX] Services autoconfiguration with PHP8 Attributes and Interfaces #14154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
API
…ture services using it + added tests.
…on for future services using it + added tests.
…for future services using it + added tests.
…ion for future services using it + added tests.
…n for future services using it + added tests.
… for future services using it + added tests.
…on for future services using it + added tests.
… for future services using it + added tests.
…tion for future services using it + added tests.
…ion for future services using it + added tests.
… autoconfiguration for future services using it + added tests.
…ansformerInterface + tests.
ffouillet
force-pushed
the
feat/services-autoconfiguration-and-php8-attributes
branch
from
136c3c3
to
2793f1f
Compare
|
Hello @ffouillet 👋🏼! If you would like, you can rebase this PR and target it against I just wanted to let you know your work won't be gone, and I believe we'll see this feature in the Sylius soon :D. |
|
Hello @ffouillet 👋🏼 Thanks for starting this initiative! |
|
Hi @jakubtobiasz, I'm glad the work I initiated will be used in Sylius :). Thanks for having set me as a co-author in the new PR! |
This was referenced Sep 13, 2023
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…e (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 8d18081 Provide autoconfiguration with attributes for ApiBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…undle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- a8e817d Provide autoconfiguration with attributes for PaymentBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…dle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 8bb6655 Provide autoconfiguration with attributes for PayumBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…le (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 3e025ca Provide autoconfiguration with attributes for CoreBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…ndle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 2e04d4c Provide autoconfiguration with attributes for LocaleBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…Bundle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 2830ff8 Provide autoconfiguration with attributes for CurrencyBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…dle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 0a26e7a Improve autoconfiguration with attributes for OrderBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…undle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 2d2247a Improve autoconfiguration with attributes for ProductBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…Bundle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- c9ce032 Provide autoconfiguration with attributes for TaxationBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…Bundle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- b41b4bc Provide autoconfiguration with attributes for ShippingBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…nBundle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 56901d3 Provide autoconfiguration with attributes for PromotionBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…eBundle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 223cada Provide autoconfiguration with attributes for AttributeBundle
TheMilek
added a commit
that referenced
this pull request
Sep 13, 2023
…undle (jakubtobiasz) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | continuation of #14154 | License | MIT Thanks @ffouillet for starting this initiative 🥳! Commits ------- 3c2f26a Provide autoconfiguration with attributes for ChannelBundle 0342759 Rename AsChannelContextRequestResolver.php to AsRequestBasedChannelResolver.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature aims to improve developer experience by allowing to autoconfigure custom services on every bundle where possible thanks to interfaces and PHP8 Attributes.
Custom services reference services that can be created on top of Sylius extension points.
For example: A custom service implementing
ChannelContextInterfaceshould now not need anymore to be declared in services.yaml thanks to autoconfiguration.During bundle loading :
ChannelContext) that do not require arguments could be autoconfigured directly by implementing the right interface.TaxCalculatorInterface) that do require arguments should be tagged with PHP8 Attributes so that Attributes parameters can be used as service tag attributes.Concerned bundles :
Some documentation have also been added, not on every bundle.
Feel free to let me know where I can write more doc about the concerned services if necessary ;) !
Many thanks in advance for your reviews 🙂.
A huge thank you to @HeahDude who has motivated me to contribute and took of his time to help and support me through the whole process of the creation of this feature. Thank you 🙏 !!