[AdminBundle] Uncoupled AdminBundle with ShopBundle #10614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomanhez
force-pushed
the
uncoupled-adminbundle-with-shopbundle
branch
from
2e15057
to
4c8750d
Compare
pamil
suggested changes
Aug 23, 2019
src/Sylius/Bundle/AdminBundle/Resources/views/Product/_showInShopButton.html.twig
Outdated
Show resolved
Hide resolved
pamil
suggested changes
Aug 23, 2019
src/Sylius/Bundle/CoreBundle/Twig/BundleAvailableCheckerExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/services/templating.xml
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
uncoupled-adminbundle-with-shopbundle
branch
from
4c8750d
to
1384014
Compare
lchrusciel
reviewed
Aug 23, 2019
src/Sylius/Bundle/CoreBundle/Twig/BundleLoadedCheckerExtension.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
uncoupled-adminbundle-with-shopbundle
branch
from
1384014
to
0f6b868
Compare
AdamKasp
approved these changes
Aug 23, 2019
lchrusciel
approved these changes
Aug 23, 2019
lchrusciel
approved these changes
Aug 23, 2019
Tomanhez
force-pushed
the
uncoupled-adminbundle-with-shopbundle
branch
from
2201eb9
to
84afeec
Compare
pamil
suggested changes
Aug 23, 2019
Zales0123
added
the
Potential Bug
Tomanhez
force-pushed
the
uncoupled-adminbundle-with-shopbundle
branch
from
84afeec
to
eef5a90
Compare
pamil
approved these changes
Aug 23, 2019
pamil
suggested changes
Aug 23, 2019
Tomanhez
force-pushed
the
uncoupled-adminbundle-with-shopbundle
branch
from
eef5a90
to
07122b4
Compare
Tomanhez
force-pushed
the
uncoupled-adminbundle-with-shopbundle
branch
from
07122b4
to
de8a7f5
Compare
lchrusciel
approved these changes
Aug 26, 2019
|
Thank you, Tomasz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #10607
ProductShowPage after ShopBundle excluded: