Rework the order item quantity limit into a parameter

[itinance]

Sylius version affected: 1.5, 1.6, master

Description
Buying more than 9999 pieces of an article will be hard capped at 9999 as possible maximum value in service decoration of sylius.order_item_quantity_modifier.limiting.

Steps to reproduce

1. Order more than 9999 pieces of an article

or

2. look at the source code:

   Sylius/src/Sylius/Bundle/CoreBundle/Resources/config/services.xml

   Line 158 in 23aeeb5

   <argument>9999</argument>

        <service id="sylius.order_item_quantity_modifier.limiting" class="Sylius\Component\Core\Cart\Modifier\LimitingOrderItemQuantityModifier" decorates="sylius.order_item_quantity_modifier" decoration-priority="256">
            <argument type="service" id="sylius.order_item_quantity_modifier.limiting.inner" />
            <argument>9999</argument>
        </service>

Possible Solution

Such limiting values should not be set as magic values in service definition nor in source code. They rather should be parameters out of config files.

Why is it a bad idea to limit quantities to 9999? Because
a) shop owners should be able to meet there own limitation in general
b) especially for digital products a much higher limitation will be required

[lchrusciel]

Should be parametrized

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.