-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AdminBundle]: "Add rule" in shipping methods no longer opens full rule form #14009
Comments
Hi @sabat24 ! thanks for the issue. I looked at it and could not reproduce the issue under https://master.demo.sylius.com/admin/shipping-methods/ (maybe it's already fixed or sth) Do you mind sending us ex. loom video (https://www.loom.com/) 😄 |
Go to https://master.demo.sylius.com/admin/shipping-methods/new and click on instead of As you can see in first screenshot there are no configuration fields for the rule. |
Alright, now I see it. The first time it is chosen the input does not appear. Would you like to open a PR with the improvement? |
Sure. Will do it in few days as soon as I write Behat tests for it. |
…e separate module (coldic3) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | fixes #13845, #14009 | | License | MIT | Commits ------- c03289f [UI][DX] Extract form collection event handlers to the separate module
Hello 👋🏼, |
Sylius version affected: 1.1.11
Description
Same bug as #13463 but for Shipping Methods.
Possible Solution
Add below code to
Resources/private/js/app.js
somewhere inside$(document).ready(() => {
Side Note
There should be more generic solution to handle such things not directly related to field names nor ids. It would help us when we extending some forms and would avoid such bugs from your side each time you change field name or add something.
The text was updated successfully, but these errors were encountered: