Provide autoconfiguration with attributes for ChannelBundle #15300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
jakubtobiasz
added
the
DX
src/Sylius/Bundle/ChannelBundle/Attribute/AsChannelContextRequestResolver.php
Outdated
Show resolved
Hide resolved
| #[\Attribute(\Attribute::TARGET_CLASS)] | ||
| final class AsChannelContextRequestResolver | ||
| { | ||
| public const SERVICE_TAG = 'sylius.context.channel.request_based.resolver'; |
There was a problem hiding this comment.
Completely besides the point, but this tag name is awful, we should think of changing it to something more concise
NoResponseMate
approved these changes
Sep 13, 2023
Bunnyshell Preview Environment deletedAvailable commands:
|
TheMilek
approved these changes
Sep 13, 2023
|
Thanks, Jacob! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @ffouillet for starting this initiative 🥳!