-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide autoconfiguration with attributes #15269
Conversation
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Co-authored-by: Felix Fouillet <felix.fouillet@gmail.com>
Bunnyshell Preview Environment deletedAvailable commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this tag is used only in CoreBundle, but probably the attribute could be added to the PromotionBundle, I don't have a strong opinion, just wondering 馃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\Sylius\Bundle\CoreBundle\CatalogPromotion\Applicator\CatalogPromotionApplicator
lives in the CoreBundle, so it makes no sense to put the attribute in the PromotionBundle
.
Thanks @ffouillet for starting this initiative 馃コ!