Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Order] Text going out of the frame in the Notes section #16031

Closed
marekrzytki opened this issue Mar 21, 2024 · 2 comments · Fixed by #16076
Closed

[Order] Text going out of the frame in the Notes section #16031

marekrzytki opened this issue Mar 21, 2024 · 2 comments · Fixed by #16076
Assignees
@kulczy

Comments

@marekrzytki
Copy link

Sylius version affected: 1.12.13

Description
Notes content does not wrap text
2024-03-21_13-00

Steps to reproduce

  1. Add any product to the cart and go through checkout
  2. On the summary page put a long string value in the Extra Notes field. Value can’t have and space characters.
  3. After placing an order go to the admin panel, Order section and show details of the just placed order.

Possible Solution
Text wrap in twig template or notes field length validation.
@Wojdylak Wojdylak assigned Wojdylak and kulczy and unassigned Wojdylak Mar 22, 2024
@Wojdylak
Copy link
Member

Hi @marekrzytki

Thank you for bringing this issue to our attention. We acknowledge it as a bug. If you'd like, feel free to submit a PR - aw always appreciate community contributions.

crydotsnake added a commit to crydotsnake/Sylius that referenced this issue Mar 30, 2024
@crydotsnake
BUGFIX: [AdminBundle] Sylius#16031 wrap long text in notes section
78d6657
@crydotsnake crydotsnake mentioned this issue Mar 30, 2024
Merged
crydotsnake added a commit to crydotsnake/Sylius that referenced this issue Apr 2, 2024
@crydotsnake
BUGFIX: [AdminBundle] Sylius#16031 wrap long text in notes section
2ca103f
Wojdylak added a commit that referenced this issue Apr 3, 2024
@Wojdylak
minor #16076 BUGFIX: [AdminBundle] #16031 wrap long text in notes sec…
0e9aeb0 
…tion (crydotsnake)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.12.        <!-- see the comment below -->                  |
| Bug fix?        | yes.                                                         |
| New feature?    | no.                                                          |
| BC breaks?      | no.                                                          |
| Deprecations?   | no.    <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes #16031                       |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->

As already described in #16031 

When you have a long text in the notes info without any spaces and new lines, the text doesent wrap and therefore it breaks out of the container.

So i added a `word-break: break-word;` to the ID: `sylius-order-notes` in the `_ui.scss` file.

### Result

![SCR-20240330-mypw](https://github.com/Sylius/Sylius/assets/39345336/a7c7b395-70bf-40c3-882b-f7a1b044591e)


Commits
-------
  BUGFIX: [AdminBundle] #16031 wrap long text in notes section
@Wojdylak
Copy link
Member

Wojdylak commented Apr 3, 2024 •
edited
Loading

I am closing this issue as it has been resolved by PR #16076

@Wojdylak Wojdylak closed this as completed Apr 3, 2024
GSadee added a commit that referenced this issue Apr 3, 2024
@GSadee
Merge branch '1.12' into 1.13
46fb261 
* 1.12:
  BUGFIX: [AdminBundle] #16031 wrap long text in notes section
GSadee added a commit that referenced this issue Apr 3, 2024
@GSadee
Merge branch '1.13' into 2.0
76c12e8 
* 1.13:
  [API][Maintenance] Remove unnecessary enabled option
  [CS][DX] Refactor
  BUGFIX: [AdminBundle] #16031 wrap long text in notes section
GSadee added a commit that referenced this issue Apr 3, 2024
@GSadee
Merge branch '2.0' into api-platform-3
8047077 
* 2.0:
  [API][Maintenance] Remove unnecessary enabled option
  [CS][DX] Refactor
  BUGFIX: [AdminBundle] #16031 wrap long text in notes section
@crydotsnake crydotsnake mentioned this issue Apr 6, 2024
Merged
Wojdylak added a commit that referenced this issue Apr 8, 2024
@Wojdylak
minor #16099 BUGFIX: [ShopBundle] #16068 wrap long text in product de…
8e3cb3d 
…scription (crydotsnake)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.12.                                                        |
| Bug fix?        | yes.                                                         |
| New feature?    | no                                                           |
| BC breaks?      | no.                                                          |
| Deprecations?   | no                                                           |
| Related tickets | fixes #16068,                                                |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->

Its the same behavior as in: #16031 

![SCR-20240406-hdyh](https://github.com/Sylius/Sylius/assets/39345336/4fc9f839-3070-4b04-bde7-754fdef69307)



Commits
-------
  BUGFIX: [ShopBundle] #16068 wrap long text in product description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulczy kulczy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: [AdminBundle] #16031 wrap long text in notes section crydotsnake/Sylius
3 participants
@kulczy @Wojdylak @marekrzytki