Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Text going out of the frame in product description #16068

Closed
marekrzytki opened this issue Mar 28, 2024 · 2 comments
Closed

[UI] Text going out of the frame in product description #16068

marekrzytki opened this issue Mar 28, 2024 · 2 comments

Comments

@marekrzytki
Copy link

Sylius version affected: 1.12.13

Description
Too long product description lines going off the frame
Can be reproduced on current demo
2024-03-28_10-58

Steps to reproduce

  1. Edit any product in admin panel
  2. Fill description field with long lines text
  3. Save
  4. Check product page

Possible Solution
Possibly text wrap in description twig template
@crydotsnake
Copy link
Contributor

I could reproduce it.

As in #16076 i would suggest to introduce a new CSS Class/ID and apply the word-break: break-word; there.

Because if i would add it to one of those classes: ui bottom attached tab segment active i'm not sure, if it could break something at any other place.

Wdyt @Rafikooo, @Wojdylak ?

@crydotsnake crydotsnake mentioned this issue Apr 3, 2024
Merged
crydotsnake added a commit to crydotsnake/Sylius that referenced this issue Apr 6, 2024
@crydotsnake
BUGFIX: [ShopBundle] Sylius#16068 wrap long text in product description
f004659
@crydotsnake crydotsnake mentioned this issue Apr 6, 2024
Merged
Wojdylak added a commit that referenced this issue Apr 8, 2024
@Wojdylak
minor #16099 BUGFIX: [ShopBundle] #16068 wrap long text in product de…
8e3cb3d 
…scription (crydotsnake)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.12.                                                        |
| Bug fix?        | yes.                                                         |
| New feature?    | no                                                           |
| BC breaks?      | no.                                                          |
| Deprecations?   | no                                                           |
| Related tickets | fixes #16068,                                                |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->

Its the same behavior as in: #16031 

![SCR-20240406-hdyh](https://github.com/Sylius/Sylius/assets/39345336/4fc9f839-3070-4b04-bde7-754fdef69307)



Commits
-------
  BUGFIX: [ShopBundle] #16068 wrap long text in product description
@Wojdylak
Copy link
Member

Wojdylak commented Apr 8, 2024

I am closing this issue as it has been resolved by PR #16099

@Wojdylak Wojdylak closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wojdylak @crydotsnake @marekrzytki