Set shipment state to onhold before process payment. #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,8 +107,7 @@ public function updateShipmentStatesReady(GenericEvent $event) | |||
| { | |||
| $this->shippingProcessor->updateShipmentStates( | |||
| $this->getOrder($event)->getShipments(), | |||
| ShipmentInterface::STATE_READY, | |||
| ShipmentInterface::STATE_CHECKOUT | |||
| ShipmentInterface::STATE_READY | |||
There was a problem hiding this comment.
I removed the ShipmentInterface::STATE_CHECKOUT because shipment state might change from STATE_ONHOLD to STATE_READY.
|
/cc @winzou the Sylius state expert. |
|
+1! |
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 17, 2014
Set shipment state to onhold before process payment.
|
Thanks Ka Yue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/Sylius/Sylius/wiki/Status
In the "Checkout finished (not paid)" step, shipment state should be changed to "onhold".