Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default variant on-hand should be 0. #1147

Merged
merged 1 commit into from
Mar 3, 2014
Merged

Default variant on-hand should be 0. #1147

merged 1 commit into from
Mar 3, 2014

Conversation

kayue
Copy link
Contributor

@kayue kayue commented Mar 3, 2014

Agree?

@stloyd stloyd added the RFC label Mar 3, 2014
@winzou
Copy link
Contributor

winzou commented Mar 3, 2014

Correct.

@QuingKhaos
Copy link
Contributor

+1

@umpirsky
Copy link
Contributor

umpirsky commented Mar 3, 2014

👍

Ping @pjedrzejewski

winzou added a commit that referenced this pull request Mar 3, 2014
@winzou
Merge pull request #1147 from kayue/patch-9
5273fc6 
Default variant on-hand should be 0.
@winzou winzou merged commit 5273fc6 into Sylius:master Mar 3, 2014
@winzou
Copy link
Contributor

winzou commented Mar 3, 2014

Thanks!

@pjedrzejewski
Copy link
Member

👍

@stloyd stloyd added this to the 1.0.0-BETA1 milestone Mar 3, 2014
@stloyd stloyd added Enhancement and removed RFC labels Mar 3, 2014
@kayue kayue deleted the patch-9 branch July 29, 2014 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kayue @winzou @QuingKhaos @umpirsky @pjedrzejewski @stloyd