Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve awaiting_payment state in resolver #11535

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

kayue
Copy link
Contributor

@kayue kayue commented May 30, 2020

OrderPaymentStateResolver should resolve awaiting_payment state when there is payment under processing. This is needed to handle asynchronous payment confirmation.

For asynchronous payment methods, it can take up to several days to confirm whether the payment has been successful. During this time, the payment cannot be guaranteed. The status of the payment’s Charge object is initially set to pending, until the payment has been confirmed as successful or failed. ACH debits are an example of an asynchronous method: with these debits, it takes a few days to confirm that the payment has succeeded.

https://stripe.com/docs/sources#synchronous-or-asynchronous-confirmation

Q A
Branch? 1.6
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

kayue added 2 commits May 30, 2020 10:53
OrderPaymentStateResolver should resolve awaiting_payment state when there is payment under processing. This is needed to handle asynchronous payment confirmation.
@kayue kayue requested a review from a team as a code owner May 30, 2020 02:57
@pamil pamil added the Feature New feature proposals. label Jun 1, 2020
@pamil pamil merged commit 7901f9a into Sylius:master Jun 1, 2020
@pamil
Copy link
Contributor

pamil commented Jun 1, 2020

Thank you, Ka! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants