Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call the backend if the notification bar is disabled #11612

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Don't call the backend if the notification bar is disabled #11612

merged 1 commit into from
Jun 30, 2020

Conversation

mikemix
Copy link
Contributor

@mikemix mikemix commented Jun 29, 2020

Don't make unnecessary backend calls if the notification bar is missing (eg. disabled).

Q A
Branch? 1.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #11604
License MIT

@mikemix mikemix requested a review from a team as a code owner June 29, 2020 07:40
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Jun 29, 2020
@lchrusciel lchrusciel requested a review from kulczy June 30, 2020 07:29
@lchrusciel lchrusciel merged commit a2c5102 into Sylius:1.7 Jun 30, 2020
@lchrusciel
Copy link
Member

Thank you, Mike! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@kulczy kulczy kulczy approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemix @lchrusciel @kulczy