Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api][Checkout][Shipping] Shipping method integrity validation #11860

Merged
merged 3 commits into from
Sep 22, 2020
Merged

[Api][Checkout][Shipping] Shipping method integrity validation #11860

merged 3 commits into from
Sep 22, 2020

Conversation

Tomanhez
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@Tomanhez Tomanhez requested a review from a team as a code owner September 17, 2020 18:44
@Tomanhez Tomanhez changed the title [Shop][Checkout][Shipping] Shipping method integrity validation [Api][Checkout][Shipping] Shipping method integrity validation Sep 17, 2020
@GSadee GSadee added the API APIs related issues and PRs. label Sep 18, 2020
@Tomanhez Tomanhez force-pushed the shipping-method0integrity branch 4 times, most recently from 037ed23 to b288ff0 Compare September 18, 2020 09:29
GSadee
GSadee reviewed Sep 18, 2020
View reviewed changes
src/Sylius/Bundle/ApiBundle/Resources/config/validation/ShippingMethod.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/validation/ShippingMethod.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/validation/ShippingMethod.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/validation/ShippingMethod.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderShippingMethodEligibility.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderShippingMethodEligibilityValidator.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderShippingMethodEligibilityValidator.php Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the shipping-method0integrity branch 4 times, most recently from 3fdadac to 1d637e8 Compare September 20, 2020 18:36
@GSadee GSadee merged commit a0fd383 into Sylius:master Sep 22, 2020
@GSadee
Copy link
Member

GSadee commented Sep 22, 2020

Thanks, Tomasz! 🥇

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stloyd stloyd stloyd left review comments

@arti0090 arti0090 arti0090 left review comments

@GSadee GSadee GSadee approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tomanhez @GSadee @stloyd @AdamKasp @arti0090