Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API]Payment Method integrity check #11863

Merged
merged 6 commits into from
Sep 22, 2020
Merged

[API]Payment Method integrity check #11863

merged 6 commits into from
Sep 22, 2020

Conversation

arti0090
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@arti0090 arti0090 requested a review from a team as a code owner September 18, 2020 10:46
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Sep 18, 2020
@arti0090 arti0090 force-pushed the api-payment-method-integrity branch 2 times, most recently from 42e77c8 to fec1429 Compare September 21, 2020 12:05
GSadee
GSadee approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the rebase is needed

src/Sylius/Bundle/ApiBundle/Validator/Constraints/PaymentMethodEligibilityValidator.php Outdated Show resolved Hide resolved
...Sylius/Bundle/ApiBundle/spec/Validator/Constraints/PaymentMethodEligibilityValidatorSpec.php Outdated Show resolved Hide resolved
...Sylius/Bundle/ApiBundle/spec/Validator/Constraints/PaymentMethodEligibilityValidatorSpec.php Outdated Show resolved Hide resolved
@GSadee GSadee merged commit 34c4668 into Sylius:master Sep 22, 2020
@GSadee
Copy link
Member

GSadee commented Sep 22, 2020

Thank you, @arti0090! 🎉

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@GSadee GSadee GSadee approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arti0090 @GSadee @AdamKasp @Tomanhez