Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix | Don't suggest old format for template locations #12046

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Nov 13, 2020

Q A
Branch? 1.7 / 1.8
Bug fix? yes
New feature? no
BC breaks? no(?)
Deprecations? no
License MIT

With old format in Symfony 5 there is fatal error that templates cannot be found, in code those locations are correct already:

@stloyd stloyd requested a review from a team as a code owner November 13, 2020 13:53
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Nov 16, 2020
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it could be even open to 1.7 👌

@lchrusciel lchrusciel changed the base branch from 1.8 to 1.7 November 16, 2020 08:41
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "bugfix/docs-resource-templates" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel merged commit 3fa6069 into Sylius:1.7 Nov 16, 2020
@lchrusciel
Copy link
Member

Thanks, Joseph! 🎉

@stloyd stloyd deleted the bugfix/docs-resource-templates branch November 16, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants