Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use existing interface instead of re-declaring same methods #1240

Merged
merged 1 commit into from
Mar 20, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Mar 20, 2014

No description provided.

@stloyd stloyd added the Bug Fix label Mar 20, 2014
@stloyd stloyd added this to the 1.0.0-BETA1 milestone Mar 20, 2014
@makasim
Copy link
Contributor

makasim commented Mar 20, 2014

Like the idea in general but we have to be very careful when it comes to interfaces.

Mass of the not consistent interfaces can lead us to hell.

pjedrzejewski pushed a commit that referenced this pull request Mar 20, 2014
Re-use existing interface instead of re-declaring same methods
@pjedrzejewski pjedrzejewski merged commit 9ac6d1d into Sylius:master Mar 20, 2014
@pjedrzejewski
Copy link
Member

Thank you Joseph!

@stloyd stloyd deleted the bugfix/core_interface branch March 20, 2014 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants