Recalculate order adjustments total after adjustment is added or remo…

[kayue]

Q	A
Branch?	1.9
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets
License	MIT

In the current code (1.8 at least) adjustment total is not being updated after shipping fee is added to order. For example in the code below:

Sylius/src/Sylius/Component/Core/OrderProcessing/ShippingChargesProcessor.php

Lines 51 to 59 in f486b80

	$shippingCharge = $this->shippingChargesCalculator->calculate($shipment);
	/** @var AdjustmentInterface $adjustment */
	$adjustment = $this->adjustmentFactory->createNew();
	$adjustment->setType(AdjustmentInterface::SHIPPING_ADJUSTMENT);
	$adjustment->setAmount($shippingCharge);
	$adjustment->setLabel($shipment->getMethod()->getName());
	$order->addAdjustment($adjustment);

Recalculation is designed to happen when $adjustment->setAmount() is called, however the Order object is only added after. (in the last line)

Proposed fixed is to trigger recalculateAdjustmentsTotal() whenever adjustment is added (or removed) to order.

[Zales0123]

Generally, I think it's a good idea 👍 2 notes from me:

• we should probably add such a recalculation in every adjustable object (Order, OrderItem and OrderItemUnit)
• I would start with changing the spec for the proper objects (e.g. it_adds_adjustments_properly for the Order) and call $this->getAdjustmentsTotal()->shouldReturn(XXX); at the end

🖖

[SirDomin]

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-6" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

[Zales0123]

OR 😄 in fact I'm not 100% sure should we merge it without adding the same feature on OrderItem, OrderItemUnit and Shipment level - currently no adjustment is added to Order directly, so we cannot be sure it does not break anything, as these change would not be covered by any Behat scenario 💃

The base branch was changed.

[github-actions]

Bunnyshell Preview Environment deleted

Available commands:

• /bns:deploy to redeploy the environment

[GSadee]

Thanks, @kayue! 🥇