Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EntityToIdentifier stuff into ObjectToIdentifier #1256

Merged
merged 1 commit into from
Mar 26, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Mar 21, 2014

Remove hardcoded dependency on Doctrine ORM, and allow instead to register transformer for every persistence type (ORM, ODM, PHPCR).

This is alternative approach to the #1244. Fixes #1199.

@stloyd stloyd added this to the 1.0.0-BETA1 milestone Mar 21, 2014
@stloyd stloyd mentioned this pull request Mar 21, 2014
@stloyd
Copy link
Contributor Author

stloyd commented Mar 21, 2014

Just additional note: if you remove (read: don't use) ORM in your project, the default usage of the entity_to_identifier form types will still work, as I'm creating an alias to the ODM version if ORM is not found (same goes with PHPCR, but this is last, so it's aliased only in case there is no ORM/ODM declared).

@arnolanglade
Copy link
Contributor

yep, it better than mine! 👍

Remove hardcoded dependency on Doctrine ORM, and allow instead to register transformer for every persistence type (ORM, ODM, PHP-CR).
@stloyd
Copy link
Contributor Author

stloyd commented Mar 25, 2014

@Sylius Guys, please share your opinions about this...

@jjanvier
Copy link
Contributor

👍 easier to understand that @Arn0d's PR :trollface:

pjedrzejewski pushed a commit that referenced this pull request Mar 26, 2014
Refactor EntityToIdentifier stuff into ObjectToIdentifier
@pjedrzejewski pjedrzejewski merged commit 4dd86fc into Sylius:master Mar 26, 2014
@pjedrzejewski
Copy link
Member

Thanks Joseph!

@stloyd stloyd deleted the feature/form_object_transformer branch March 26, 2014 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceBundle has a dependence on the doctrine.orm.entity_manager service
4 participants