Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sprintf parameters order #12712

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Fix sprintf parameters order #12712

merged 2 commits into from
Dec 22, 2022

Conversation

Creeperface01
Copy link
Contributor

@Creeperface01 Creeperface01 commented Jun 15, 2021 •
edited by coldic3

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

@Creeperface01 Creeperface01 requested a review from a team as a code owner June 15, 2021 08:13
@Zales0123 Zales0123 added Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience. labels Jun 17, 2021
Zales0123
Zales0123 approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@Zales0123
Copy link
Member

@Creeperface01 we need a small fix in AvailableProductOptionValuesResolverSpec 🖖

@Creeperface01
Copy link
Contributor Author

Creeperface01 commented Nov 21, 2021 •
edited

@Creeperface01 we need a small fix in AvailableProductOptionValuesResolverSpec 🖖

@Zales0123 Is it ok now?

@Creeperface01 Creeperface01 changed the base branch from 1.9 to 1.12 September 4, 2022 07:00
@coldic3 coldic3 changed the base branch from 1.12 to 1.11 December 22, 2022 09:15
@jakubtobiasz
Copy link
Contributor

For future readers:
We are aware of the problem with one of builds configuration, and we are sure it is not related to this PR, so I merge it :).

@jakubtobiasz jakubtobiasz merged commit 2bb3a0f into Sylius:1.11 Dec 22, 2022
@jakubtobiasz
Copy link
Contributor

Thank you, @Creeperface01! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@coldic3 coldic3 coldic3 approved these changes

@Rafikooo Rafikooo Rafikooo approved these changes

@everwhatever everwhatever everwhatever approved these changes

@TheMilek TheMilek TheMilek approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Creeperface01 @Zales0123 @jakubtobiasz @NoResponseMate @coldic3 @Rafikooo @everwhatever @TheMilek