-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CatalogPromotion] Use Catalog Promotion rule during application #13014
Merged
GSadee
merged 5 commits into
Sylius:master
from
Zales0123:use-cp-rule-during-cp-application
Aug 31, 2021
Merged
[CatalogPromotion] Use Catalog Promotion rule during application #13014
GSadee
merged 5 commits into
Sylius:master
from
Zales0123:use-cp-rule-during-cp-application
Aug 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Aug 27, 2021
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | |
Related tickets | based on #13001 |
License | MIT |
Zales0123
force-pushed
the
use-cp-rule-during-cp-application
branch
from
August 27, 2021 07:36
c144119
to
d2aafcd
Compare
SirDomin
reviewed
Aug 27, 2021
src/Sylius/Bundle/CoreBundle/Provider/CatalogPromotionProductsProvider.php
Outdated
Show resolved
Hide resolved
AdamKasp
reviewed
Aug 30, 2021
src/Sylius/Bundle/CoreBundle/Provider/CatalogPromotionProductsProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Provider/CatalogPromotionProductsProvider.php
Outdated
Show resolved
Hide resolved
Zales0123
force-pushed
the
use-cp-rule-during-cp-application
branch
from
August 30, 2021 11:15
d2aafcd
to
53a7e9c
Compare
Zales0123
force-pushed
the
use-cp-rule-during-cp-application
branch
from
August 30, 2021 11:16
53a7e9c
to
a1378c9
Compare
GSadee
reviewed
Aug 31, 2021
src/Sylius/Bundle/CoreBundle/Processor/DummyCatalogPromotionProcessor.php
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/DummyCatalogPromotionProcessor.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Provider/CatalogPromotionProductsProvider.php
Outdated
Show resolved
Hide resolved
Zales0123
force-pushed
the
use-cp-rule-during-cp-application
branch
from
August 31, 2021 06:46
df81536
to
4184f07
Compare
Zales0123
force-pushed
the
use-cp-rule-during-cp-application
branch
from
August 31, 2021 07:11
4184f07
to
28e9cb6
Compare
GSadee
approved these changes
Aug 31, 2021
Arminek
approved these changes
Aug 31, 2021
Thank you, Mateusz! 🥇 |
lchrusciel
reviewed
Aug 31, 2021
Comment on lines
+49
to
+62
/** @var string $variantCode */ | ||
foreach ($configuration as $variantCode) { | ||
/** @var ProductVariantInterface|null $variant */ | ||
$variant = $this->productVariantRepository->findOneBy(['code' => $variantCode]); | ||
if ($variant === null) { | ||
continue; | ||
} | ||
|
||
if (!in_array($variant, $variants)) { | ||
$variants[] = $variant; | ||
} | ||
} | ||
|
||
return $variants; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't it work?
Suggested change
/** @var string $variantCode */ | |
foreach ($configuration as $variantCode) { | |
/** @var ProductVariantInterface|null $variant */ | |
$variant = $this->productVariantRepository->findOneBy(['code' => $variantCode]); | |
if ($variant === null) { | |
continue; | |
} | |
if (!in_array($variant, $variants)) { | |
$variants[] = $variant; | |
} | |
} | |
return $variants; | |
return $this->productVariantRepository->findBy(['code' => $configuration]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.