Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShippingBundle] Translation shipping calculator options #1304

Merged
merged 1 commit into from
Mar 30, 2014
Merged

[ShippingBundle] Translation shipping calculator options #1304

merged 1 commit into from
Mar 30, 2014

Conversation

Wasper
Copy link
Contributor

@Wasper Wasper commented Mar 30, 2014

Everything is in the title :)
I think it might be useful

@Wasper Wasper changed the title Translation shipping calculator options [ShippingBundle] Translation shipping calculator options Mar 30, 2014
@@ -20,17 +20,21 @@ sylius:

shipping_calculator:
flat_rate_configuration:
option_title: Flat rate per shipment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for label instead of option_title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stloyd stloyd added this to the 1.0.0-BETA1 milestone Mar 30, 2014
@Wasper
Copy link
Contributor Author

Wasper commented Mar 30, 2014

@stloyd update

@Wasper
Copy link
Contributor Author

Wasper commented Mar 30, 2014

Allowed memory size in 5.3 build.. every time

stloyd added a commit that referenced this pull request Mar 30, 2014
[ShippingBundle] Translation shipping calculator options
@stloyd stloyd merged commit 2d9002c into Sylius:master Mar 30, 2014
@stloyd
Copy link
Contributor

stloyd commented Mar 30, 2014

Thanks Artur! And yeah we know that the 5.3 is failing sometimes ;)

@pjedrzejewski
Copy link
Member

👍

1 similar comment
@umpirsky
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants