Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotion][API] Apply catalog promotion in proper channels #13081

Merged
merged 5 commits into from
Sep 10, 2021
Merged

[CatalogPromotion][API] Apply catalog promotion in proper channels #13081

merged 5 commits into from
Sep 10, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Sep 9, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets #13009
License MIT

@GSadee GSadee added Feature New feature proposals. API APIs related issues and PRs. labels Sep 9, 2021
@GSadee GSadee requested a review from a team as a code owner September 9, 2021 10:17
@GSadee GSadee force-pushed the applying-catalog-promotions-in-proper-channels branch from 9092c4d to cd1fe71 Compare September 9, 2021 10:39
arti0090
arti0090 approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@arti0090 arti0090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is still failing on build but I approve. Depending on which will be merged first
(#13080) rebase might be needed :)

@GSadee GSadee force-pushed the applying-catalog-promotions-in-proper-channels branch from c8c92c4 to e01d169 Compare September 10, 2021 05:27
@GSadee GSadee force-pushed the applying-catalog-promotions-in-proper-channels branch from e01d169 to 8305c48 Compare September 10, 2021 06:35
@AdamKasp AdamKasp merged commit 7be6878 into Sylius:master Sep 10, 2021
@AdamKasp
Copy link
Contributor

Thanks, Grzegorz! 🎉

@GSadee GSadee deleted the applying-catalog-promotions-in-proper-channels branch September 10, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamKasp AdamKasp AdamKasp approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GSadee @AdamKasp @arti0090