PHP 7.4 syntax in Behat #13116
Merged
PHP 7.4 syntax in Behat #13116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Sep 16, 2021
Zales0123
commented
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | based on #13040, related to #12891 |
| License | MIT |
Zales0123
added
Enhancement
Zales0123
force-pushed
the
php7.4-syntax-behat
branch
from
a46c51b
to
a99d3b2
Compare
GSadee
approved these changes
Sep 17, 2021
|
|
||
| /** @var ShowPageInterface */ | ||
| private $showPage; | ||
| private \Sylius\Behat\Page\Admin\Shipment\ShowPageInterface $showPage; |
There was a problem hiding this comment.
Suggested change
| private \Sylius\Behat\Page\Admin\Shipment\ShowPageInterface $showPage; | |
| private ShowPageInterface $showPage; |
|
|
||
| /** @var ShowPageInterface */ | ||
| private $orderShowPage; | ||
| private \Sylius\Behat\Page\Shop\Account\Order\ShowPageInterface $orderShowPage; |
There was a problem hiding this comment.
Suggested change
| private \Sylius\Behat\Page\Shop\Account\Order\ShowPageInterface $orderShowPage; | |
| private ShowPageInterface $orderShowPage; |
|
|
||
| /** @var IndexPageInterface */ | ||
| private $indexPage; | ||
| private \Sylius\Behat\Page\Shop\Product\IndexPageInterface $indexPage; |
There was a problem hiding this comment.
Suggested change
| private \Sylius\Behat\Page\Shop\Product\IndexPageInterface $indexPage; | |
| private IndexPageInterface $indexPage; |
|
Thank you, Mateusz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.