Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Payum 0.8 #1336

Merged
merged 1 commit into from
Apr 8, 2014
Merged

Update to Payum 0.8 #1336

merged 1 commit into from
Apr 8, 2014

Conversation

winzou
Copy link
Contributor

@winzou winzou commented Apr 8, 2014

Seems that be2bill onsite is not properly working on version 0.7.

@stloyd
Copy link
Contributor

stloyd commented Apr 8, 2014

This is not correct fix. You have to update also main composer.json file, as well as the composer.lock.

"payum/payum-bundle": "~0.7.3",
"payum/payum": "~0.7.2"
"payum/payum-bundle": "~0.8",
"payum/payum": "~0.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.8.*, that was discussed several times why we cannot use ~0.8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I wanted to switch to >=0.7.3,<0.9

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to set 0.8.* since there are some impr were done, I am going to update SyliusPayumBundle after we swith on it

@makasim
Copy link
Contributor

makasim commented Apr 8, 2014

sylius standard has also be updated.

@winzou
Copy link
Contributor Author

winzou commented Apr 8, 2014

@stloyd @makasim fixed, sorry for too fast PR.

@makasim
Copy link
Contributor

makasim commented Apr 8, 2014

looks good now.

@stloyd
Copy link
Contributor

stloyd commented Apr 8, 2014

@pjedrzejewski 👍

@winzou
Copy link
Contributor Author

winzou commented Apr 8, 2014

@pjedrzejewski can it be merged before components?

pjedrzejewski pushed a commit that referenced this pull request Apr 8, 2014
@pjedrzejewski pjedrzejewski merged commit 97badcd into Sylius:master Apr 8, 2014
@pjedrzejewski
Copy link
Member

Thanks Alexandre!

@winzou winzou deleted the update/pay branch April 9, 2014 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants