Basic implementation of different product properties types #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
property can be created for each type.
defined as string to text ones.
| $objectValue = implode(',', $objectValue);; | ||
| } | ||
| if ($objectValue !== $value) { | ||
| throw new \Exception(sprintf('%s object::%s has "%s" value but "%s" expected', $type, $property, $objectValue, $value)); |
There was a problem hiding this comment.
I would go with ExpectationException here.
|
I'll update the lock! Thanks guys! |
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 11, 2013
Basic implementation of different product properties types
umpirsky
added a commit
that referenced
this pull request
Aug 26, 2013
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 26, 2013
Used listener instead of hacky hack in Twig extension, fixes #14.
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 27, 2013
Container should be set on any Step implementing ...
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 27, 2013
Added default templates and routng config
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 27, 2013
French translations for SyliusShippingBundle
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 27, 2013
Converted translations to xliff format
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 29, 2013
French translations for SyliusShippingBundle
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 29, 2013
Converted translations to xliff format
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 29, 2013
Container should be set on any Step implementing ...
umpirsky
added a commit
that referenced
this pull request
Aug 29, 2013
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 29, 2013
Used listener instead of hacky hack in Twig extension, fixes #14.
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 29, 2013
Added default templates and routng config
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 29, 2013
plug inversed by on transaction to make for a valid query
mtotheikle
pushed a commit
to Limelyte/Sylius
that referenced
this pull request
Jan 22, 2014
mtotheikle
pushed a commit
to Limelyte/Sylius
that referenced
this pull request
Jan 22, 2014
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 8, 2016
[Attribute] Final fixes in attribute scenarios
CoderMaggie
pushed a commit
to CoderMaggie/Sylius
that referenced
this pull request
Jun 1, 2016
…tion [CJMAX-13] Integrated password change page
Zales0123
pushed a commit
that referenced
this pull request
Mar 14, 2022
This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT There was a possibility to load a page within an iframe which is enabling to the possibility to perform a clickjacking attack. <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 0886078 listener added to finish response with X-Frame-Options sameorigin header c236431 suggested review changes
Zales0123
added a commit
that referenced
this pull request
Mar 14, 2022
…ers and clickjacking (ernestWarwas, lchrusciel, GSadee, Zales0123, Rafikooo) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT This PR aims to solve 3 issues: 1. Possibility to inject SVGs with scripts (https://rietta.com/blog/svg-xss-injection-attacks/) 2. Possibility to check admin pages with back button after logging out due to wrong cache'ing configuration 3. Clickjacking while rendering Sylius in iframe (https://portswigger.net/web-security/clickjacking) <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 0886078 listener added to finish response with X-Frame-Options sameorigin header c236431 suggested review changes 67de9e8 bug #14 [Security] Clickjacking vulnerability fixed (ernestWarwas) 4b6a77a [UI] Force no-store cache directives for admin and customer account section 691b700 [Maintenace] Test existence of new cache headers 08d0f5a Remove type declarations for properties due to supporting PHP 7.3 94366fd Minor fixes for specs and unit tests of cache control subscribers 5dee3dc [Behat] Add scenarios for securing access to account and dashboard after logging out d4bf36c [Behat] Extract browser element and context afa04e3 Replace str_contains with strpos method to support PHP 7 b00eb51 [PHPUnit] Move subscribers tests to main directory 253f66b bug #11 [Security] Set cache control directives to fix security leak after logging out and using back button (lchrusciel, GSadee) 46ed54b [Security] XSS - SVG file upload vulnerability fixed 6ccc2d6 bug #12 [Security] XSS - SVG file upload vulnerability fixed (Rafikooo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of basic property types.
Depended PRs:
Sylius/SyliusWebBundle#8
Sylius/SyliusAssortmentBundle#55
Sylius/SyliusShippingBundle#10
First all depended PRs should be merged and then we should update composer.lock.
I find some issue with /home/leszek/projects/Sylius/vendor/sylius/addressing-bundle/Sylius/Bundle/AddressingBundle/Form/EventListener/ResizeZoneMemberCollectionListener.php after upgrade to master of Symfony.