Inject dependencies into FlowBundle\ProcessController. #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good idea, at first, I thought FlowBundle is too specific to extract a component, but I believe we can separate the Request & Session, the rest of architecture should work just fine! |
|
Test on PHP 5.3 times out, but no errors occurred. |
| { | ||
| private $processCoordinator; | ||
| private $processContext; |
There was a problem hiding this comment.
Can you define them as protected and add docblocks? Thanks!
…g ContainerAware.
winzou
added a commit
that referenced
this pull request
May 9, 2014
Inject dependencies into FlowBundle\ProcessController.
|
Nice step forward, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to refactor FlowBundle into a Component + Bundle as this would be useful for Silex, Drupal and projects using Symfony Components but not the whole thing.
This is a very small first step into that direction.