[Locale][API] Additional locale code validation #14880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Mar 22, 2023
NoResponseMate
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
NoResponseMate
added
API
NoResponseMate
force-pushed
the
api/locale-invalid-code-validation
branch
from
1bc0776
to
caba7cb
Compare
coldic3
approved these changes
Mar 23, 2023
jakubtobiasz
approved these changes
Mar 23, 2023
NoResponseMate
force-pushed
the
api/locale-invalid-code-validation
branch
from
caba7cb
to
9150ece
Compare
GSadee
reviewed
Mar 24, 2023
src/Sylius/Bundle/LocaleBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
NoResponseMate
force-pushed
the
api/locale-invalid-code-validation
branch
from
9150ece
to
e514c99
Compare
GSadee
approved these changes
Mar 27, 2023
| Then I should be notified that the code is invalid | ||
|
|
||
| @api @no-ui | ||
| Scenario: Trying to add a locale with an non-existent code |
There was a problem hiding this comment.
Suggested change
| Scenario: Trying to add a locale with an non-existent code | |
| Scenario: Trying to add a locale with a non-existent code |
|
Thank you, Jan! 🥇 |
GSadee
added a commit
that referenced
this pull request
Mar 21, 2024
…nd cleanup obsolete options (NoResponseMate) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no? | | Deprecations? | no | | Related tickets | #14880, #15472 | | License | MIT | Commits ------- ae04f10 [Currency] Add `Currency` constraint to code field c0a77ac [API][Behat] Test currency code validation d524f7a [Addressing] Remove obsolete country code validation 75b2d9e [Locale] Remove obsolete locale code validation bcba0c9 [Currency] Remove obsolete currency code validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.