[API][Addressing] Enhance Country code validation #15472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Oct 26, 2023
NoResponseMate
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | kinda |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
NoResponseMate
added
Enhancement
Bunnyshell Preview Environment deletedAvailable commands:
|
diimpp
previously approved these changes
Oct 30, 2023
src/Sylius/Behat/Context/Api/Admin/ManagingCountriesContext.php
Outdated
Show resolved
Hide resolved
NoResponseMate
force-pushed
the
SYL-3146/add-country-code-validation
branch
from
be6b5ce
to
19c92d7
Compare
diimpp
reviewed
Oct 31, 2023
src/Sylius/Bundle/AddressingBundle/Resources/translations/validators.en.yml
Show resolved
Hide resolved
src/Sylius/Bundle/AddressingBundle/Resources/config/validation/Country.xml
Show resolved
Hide resolved
NoResponseMate
force-pushed
the
SYL-3146/add-country-code-validation
branch
from
19c92d7
to
58f0033
Compare
probot-autolabeler
bot
added
the
Maintenance
diimpp
previously approved these changes
Nov 9, 2023
Rafikooo
previously approved these changes
Nov 16, 2023
oallain
previously approved these changes
Nov 24, 2023
Rafikooo
dismissed stale reviews from oallain, diimpp, and themself
via
81b7bfd
Rafikooo
force-pushed
the
SYL-3146/add-country-code-validation
branch
from
58f0033
to
81b7bfd
Compare
Rafikooo
approved these changes
Nov 24, 2023
diimpp
approved these changes
Nov 24, 2023
jakubtobiasz
approved these changes
Nov 26, 2023
|
Thank you, @NoResponseMate! |
GSadee
added a commit
that referenced
this pull request
Mar 21, 2024
…nd cleanup obsolete options (NoResponseMate) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no? | | Deprecations? | no | | Related tickets | #14880, #15472 | | License | MIT | Commits ------- ae04f10 [Currency] Add `Currency` constraint to code field c0a77ac [API][Behat] Test currency code validation d524f7a [Addressing] Remove obsolete country code validation 75b2d9e [Locale] Remove obsolete locale code validation bcba0c9 [Currency] Remove obsolete currency code validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.