-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PriceHistory] Asynchronous lowest price processing #14904
Merged
NoResponseMate
merged 4 commits into
Sylius:1.13
from
Rafikooo:SYL-2805/leftovers-to-transfer
Apr 3, 2023
Merged
[PriceHistory] Asynchronous lowest price processing #14904
NoResponseMate
merged 4 commits into
Sylius:1.13
from
Rafikooo:SYL-2805/leftovers-to-transfer
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rafikooo
commented
Mar 30, 2023
Q | A |
---|---|
Branch? | 1.13 |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Related tickets | Sylius/PriceHistoryPlugin#69, #14882 |
License | MIT |
Rafikooo
added
Feature
New feature proposals.
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
labels
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observers need to be updated as well, ATM they still work synchronously
NoResponseMate
approved these changes
Mar 31, 2023
GSadee
reviewed
Mar 31, 2023
src/Sylius/Bundle/CoreBundle/Resources/config/app/messenger.yaml
Outdated
Show resolved
Hide resolved
NoResponseMate
approved these changes
Apr 3, 2023
Thank you, @Rafikooo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Feature
New feature proposals.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.