Add Login page to the new Admin Panel #15352
Conversation
jakubtobiasz
commented
Sep 22, 2023
jakubtobiasz
commented
| Q | A |
|---|---|
| Branch? | bootstrap-admin-panel (2.0) |
| Bug fix? | no |
| New feature? | |
| BC breaks? | |
| Deprecations? | |
| Related tickets | based on #15350 |
| License | MIT |
jakubtobiasz
added
Admin
jakubtobiasz
force-pushed
the
bootstrap-admin-panel/add-login-page
branch
from
f10468a
to
2cecce2
Compare
Bunnyshell Preview Environment deletedAvailable commands:
|
| @@ -0,0 +1,3 @@ | |||
| {% import '@SyliusAdmin/Shared/Helper/button.html.twig' as _button %} | |||
|
|
|||
| {{ _button.primary({ text: 'sylius.ui.login'|trans, type: 'submit', class: 'btn btn-primary w-100' }) }} | |||
There was a problem hiding this comment.
I'm out of the loop on this, why there is _ prefix for _button?
There was a problem hiding this comment.
I use _ to indicate it's something imported. Same as I later started to use _context.<var> instead of just <var> to indicate from where something is coming. IMO it helps to understand from where some value is taken.
| @@ -0,0 +1,10 @@ | |||
| {% macro default(img, content, class) %} | |||
There was a problem hiding this comment.
Is there something wrong with old Macro namespace?
I'm not a against a rename per-se, but very much against Helper namespace anywhere. It's one of those Util/Helper/Service dumpster dirs, which doesn't indicate content.
--- views/Shared/Helper/avatar.html.twig
+++ views/Shared/Macro/avatar.html.twig| <div class="input-icon"> | ||
| <input type="text" placeholder="Search..." aria-label="Search in website" class="form-control "> | ||
| <span class="input-icon-addon"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" class="icon icon-tabler" width="24" height="24" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"> |
| @@ -0,0 +1,12 @@ | |||
| <form action="#" method="get" autocomplete="off" novalidate=""> | |||
| <div class="input-icon"> | |||
| <input type="text" placeholder="Search..." aria-label="Search in website" class="form-control "> | |||
There was a problem hiding this comment.
| <input type="text" placeholder="Search..." aria-label="Search in website" class="form-control "> | |
| <input type="text" placeholder="Search..." aria-label="Search in website" class="form-control"> |
placeholder needs to be translated
| @@ -0,0 +1 @@ | |||
| {{ form_row(form._password) }} | |||
There was a problem hiding this comment.
Is form._password some kind of special syntax of form element simply named this way?
| use Symfony\Contracts\Translation\TranslatorInterface; | ||
| use Symfony\UX\TwigComponent\Attribute\ExposeInTemplate; | ||
|
|
||
| final class UserDropdown |
There was a problem hiding this comment.
Just an idea,
| final class UserDropdown | |
| final class UserMenu | |
| final class UserMenuDropdown | |
| final class NavbarSecurity |
Main takeaway from this, that we should establish "public" naming scheme for components, e.g. content based, element based, etc
| {% set event_name = _context.event_prefix ~ '.form' %} | ||
|
|
||
| {{ form_start(form, {'action': path('sylius_admin_login_check'), 'attr': {'class': 'ui large loadable form', 'novalidate': 'novalidate'}}) }} | ||
| {{ sylius_template_event(event_name, _context|merge({ event_prefix: event_name })) }} |
There was a problem hiding this comment.
This action repeats several times _context|merge({event_prefix: event_name}), might be worth handling at sylius_template_event side or via macro
| @@ -0,0 +1,12 @@ | |||
| <form action="#" method="get" autocomplete="off" novalidate=""> | |||
| @@ -0,0 +1,7 @@ | |||
| {% form_theme form 'bootstrap_5_layout.html.twig' %} | |||
There was a problem hiding this comment.
Shouldn't it use intermediate sylius layout and not bootstrap directly?
There was a problem hiding this comment.
Common was the indication of Shared in the old templates.
Is it renamed temporarily to separate old/new templates or Shared is new Common, if so, then why?
Navbar for Crud is already common without clarification. For example show's specific navbar will be simply put at Shared/Crud/Show/Navbar
--- Shared/Crud/Common/Navbar
+++ Shared/Crud/Navbar
jakubtobiasz
merged commit 444f3ee
into
Sylius:bootstrap-admin-panel
